Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add set_probe method to BaseRecordingExtractorInterface #639
add set_probe method to BaseRecordingExtractorInterface #639
Changes from 2 commits
d2c465f
3a27e52
9983099
9037c96
e2b459e
8332459
30b4b40
d3f6e20
1b189ce
f2259df
18776a7
b8f793b
1b9d94c
893ec14
b946c64
645c2c0
8cd1aa8
de101e2
5dcc319
75aa8e1
d6cfc2f
6f5f9ba
9afd9a9
46f592d
d781a46
3f8cab5
e2298fa
69e5d94
5b3a999
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one note: if the probe has less channels than the recording (e.g., you want to only select the
A
channels from an Intan recording), theset_probe(..., in_place=True)
will fail.We can't do anything about it, just something to keep in mind :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alejoe91 What would this represent in a real world case?
Would it be indicative of a bad probe definition by the user?
Or are there cases where the user might actually specify a probe correctly, but extra channels show up (possibly from auxiliary sources or a mistake in SI/neo)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I think the second option is what I had in mind. You have a recording with Ephys + Aux channels and you might want to select ephys channels with the probe slicing