Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FicTrac timestamps. Coerce them to start at 0. #621

Merged
merged 9 commits into from
Oct 31, 2023

Conversation

h-mayorquin
Copy link
Collaborator

Note that this has #619 as a base.
In the context of #608.

Coercing the timestamps to start from 0 for FicTrac. In this case, the first row was actually a timestamp 0 that was modified by FicTrac logic see here:

rjdmoore/fictrac#29

Base automatically changed from add_radius_as_scaling to main October 30, 2023 17:44
@h-mayorquin h-mayorquin marked this pull request as ready for review October 30, 2023 17:56
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #621 (f0b2bdb) into main (7495597) will decrease coverage by 0.13%.
Report is 1 commits behind head on main.
The diff coverage is 70.37%.

❗ Current head f0b2bdb differs from pull request most recent head 3f103e4. Consider uploading reports for the commit 3f103e4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
- Coverage   91.25%   91.13%   -0.13%     
==========================================
  Files         106      106              
  Lines        5408     5425      +17     
==========================================
+ Hits         4935     4944       +9     
- Misses        473      481       +8     
Flag Coverage Δ
unittests 91.13% <70.37%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nterfaces/behavior/fictrac/fictracdatainterface.py 64.51% <70.37%> (-1.84%) ⬇️

@CodyCBakerPhD CodyCBakerPhD merged commit 3563ca2 into main Oct 31, 2023
34 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix_fictrac_timestamps branch October 31, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants