extracting and reshaping metadata from dynamic paths #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
# Conflicts: # src/neuroconv/utils/globbing.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
bendichter
requested review from
CodyCBakerPhD
and removed request for
CodyCBakerPhD
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # src/neuroconv/utils/path_expansion.py
for more information, see https://pre-commit.ci
|
@CodyCBakerPhD sure |
bendichter
commented
Apr 24, 2023
bendichter
commented
Apr 24, 2023
bendichter
commented
Apr 24, 2023
bendichter
commented
Apr 24, 2023
bendichter
commented
Apr 24, 2023
for more information, see https://pre-commit.ci
Co-authored-by: Ben Dichter <[email protected]>
CodyCBakerPhD
previously approved these changes
Apr 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 91.94% 91.96% +0.01%
==========================================
Files 88 88
Lines 4045 4055 +10
==========================================
+ Hits 3719 3729 +10
Misses 326 326
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodyCBakerPhD
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
expand_paths, which finds paths that match a format spec and extracts metadata