Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra electrode groups ephys #1164

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Dec 18, 2024

Should fix #1163.

Also related to #932 as that should be more or less the last place where we did not priority set.

@h-mayorquin h-mayorquin changed the title Fix electrode groups ephys Fix extra electrode groups ephys Dec 18, 2024
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@h-mayorquin h-mayorquin marked this pull request as ready for review December 19, 2024 13:59
@h-mayorquin h-mayorquin enabled auto-merge (squash) December 19, 2024 14:58
@h-mayorquin
Copy link
Collaborator Author

Thanks for the review @pauladkisson

@h-mayorquin h-mayorquin merged commit 2084d35 into main Dec 19, 2024
48 checks passed
@h-mayorquin h-mayorquin deleted the fix_electrode_groups_ephys branch December 19, 2024 15:52
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (96dfdff) to head (c8f91c7).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
+ Coverage   90.69%   90.75%   +0.06%     
==========================================
  Files         129      129              
  Lines        8189     8286      +97     
==========================================
+ Hits         7427     7520      +93     
- Misses        762      766       +4     
Flag Coverage Δ
unittests 90.75% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...erfaces/ecephys/baserecordingextractorinterface.py 93.87% <100.00%> (+0.06%) ⬆️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ecephys pipeline writing extra device and extra electrode groups when setting group_names
2 participants