-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move imports of extensions to the init of the interfaces #1144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught a copy-paste error, and added some suggestions but otherwise looks good.
src/neuroconv/datainterfaces/behavior/lightningpose/lightningposedatainterface.py
Show resolved
Hide resolved
Co-authored-by: Paul Adkisson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @h-mayorquin!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1144 +/- ##
==========================================
+ Coverage 90.67% 90.69% +0.01%
==========================================
Files 129 129
Lines 8182 8186 +4
==========================================
+ Hits 7419 7424 +5
+ Misses 763 762 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks for the review @pauladkisson . |
Fix #1114.
As discussed in the general meeting. This is the simplest solution. Later, when time allows, we will do #1143 which should be a more robust solution for the most common use case.
I added a test to assure myself that this closes #1114
I also removed some deprecated compression arguments that I missed on #1126 and fixed some type-conversion warnings from hdmf.