Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports of extensions to the init of the interfaces #1144

Merged
merged 10 commits into from
Nov 22, 2024

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Nov 15, 2024

Fix #1114.

As discussed in the general meeting. This is the simplest solution. Later, when time allows, we will do #1143 which should be a more robust solution for the most common use case.

I added a test to assure myself that this closes #1114

I also removed some deprecated compression arguments that I missed on #1126 and fixed some type-conversion warnings from hdmf.

@h-mayorquin h-mayorquin self-assigned this Nov 15, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review November 15, 2024 16:27
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught a copy-paste error, and added some suggestions but otherwise looks good.

Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @h-mayorquin!

@pauladkisson pauladkisson merged commit dcd248b into main Nov 22, 2024
40 checks passed
@pauladkisson pauladkisson deleted the move_imports_to_the_correct_place branch November 22, 2024 18:55
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (a608e90) to head (2eea323).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
+ Coverage   90.67%   90.69%   +0.01%     
==========================================
  Files         129      129              
  Lines        8182     8186       +4     
==========================================
+ Hits         7419     7424       +5     
+ Misses        763      762       -1     
Flag Coverage Δ
unittests 90.69% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nv/datainterfaces/behavior/audio/audiointerface.py 88.09% <100.00%> (+0.14%) ⬆️
...v/datainterfaces/behavior/deeplabcut/_dlc_utils.py 58.89% <100.00%> (+0.51%) ⬆️
...ces/behavior/deeplabcut/deeplabcutdatainterface.py 93.47% <100.00%> (+0.14%) ⬆️
...havior/lightningpose/lightningposedatainterface.py 95.37% <100.00%> (+0.04%) ⬆️
...atainterfaces/behavior/medpc/medpcdatainterface.py 94.38% <100.00%> (+0.06%) ⬆️
...es/ophys/tdt_fp/tdtfiberphotometrydatainterface.py 96.68% <ø> (ø)
src/neuroconv/tools/audio/audio.py 100.00% <ø> (+4.54%) ⬆️
---- 🚨 Try these New Features:

@h-mayorquin
Copy link
Collaborator Author

Thanks for the review @pauladkisson .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue with DLC interface not loading
2 participants