simpler attempt

catalystneuro · Nov 15, 2024 · 722d179 · 722d179
1 parent 7cb15e3
commit 722d179
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/neuroconv/tools/yaml_conversion_specification/_yaml_conversion_specification.py b/src/neuroconv/tools/yaml_conversion_specification/_yaml_conversion_specification.py
@@ -84,12 +84,8 @@ def run_conversion_from_yaml(
     specification_schema = load_dict_from_file(file_path=schema_folder / "yaml_conversion_specification_schema.json")
     metadata_schema = load_dict_from_file(file_path=schema_folder / "metadata_schema.json")
 
-    # Create registry and add schemas
-    registry = (
-        Registry()
-        .with_resource("metadata_schema.json", Resource.from_contents(metadata_schema))
-        .with_resource("yaml_conversion_specification_schema.json", Resource.from_contents(specification_schema))
-    )
+    # The yaml specification references the metadata schema, so we need to load it into the registry
+    registry = Registry().with_resource("metadata_schema.json", Resource.from_contents(metadata_schema))
 
     # Validate using the registry
     validate(

diff --git a/tests/test_on_data/test_yaml/test_yaml_conversion_specification.py b/tests/test_on_data/test_yaml/test_yaml_conversion_specification.py
@@ -32,7 +32,7 @@ def test_validate_example_specifications(fname):
     specification_schema = load_dict_from_file(file_path=schema_folder / "yaml_conversion_specification_schema.json")
     metadata_schema = load_dict_from_file(file_path=schema_folder / "metadata_schema.json")
 
-    # Create registry and add schemas
+    # The yaml specification references the metadata schema, so we need to load it into the registry
     registry = Registry().with_resource("metadata_schema.json", Resource.from_contents(metadata_schema))
 
     yaml_file_path = path_to_test_yml_files / fname