Fix empty nwbfile bug for write_recording (#877)

Co-authored-by: Cody Baker <[email protected]>
catalystneuro · May 25, 2024 · 5aeac19 · 5aeac19
1 parent 4e4d900
commit 5aeac19
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -31,6 +31,7 @@
 * `BaseImagingExtractor.add_to_nwbfile()` is fixed in the case where metadata is not supplied. [PR #849](https://github.com/catalystneuro/neuroconv/pull/849)
 * Prevent `SpikeGLXConverterPipe` from setting false properties on the sub-`SpikeGLXNIDQInterface`. [PR #860](https://github.com/catalystneuro/neuroconv/pull/860)
 * Fix bug when adding ragged arrays to the electrode and units table [PR #870](https://github.com/catalystneuro/neuroconv/pull/870)
+* Fix bug where `write_recording` will call an empty nwbfile when passing a path [PR #877](https://github.com/catalystneuro/neuroconv/pull/877)
 
 ### Improvements
 * Fixed docstrings related to backend configurations for various methods. [PR #822](https://github.com/catalystneuro/neuroconv/pull/822)

diff --git a/src/neuroconv/tools/spikeinterface/spikeinterface.py b/src/neuroconv/tools/spikeinterface/spikeinterface.py
@@ -940,7 +940,7 @@ def write_recording(
     ) as nwbfile_out:
         add_recording(
             recording=recording,
-            nwbfile=nwbfile,
+            nwbfile=nwbfile_out,
             starting_time=starting_time,
             metadata=metadata,
             write_as=write_as,