Add support for python 3.12 (#626)

Co-authored-by: Cody Baker <[email protected]>
Co-authored-by: Ben Dichter <[email protected]>

.github/workflows/dev-testing.yml

@@ -23,7 +23,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
     steps:
       - uses: actions/checkout@v4
       - run: git fetch --prune --unshallow --tags

.github/workflows/doctests.yml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
         os: [ubuntu-latest, macos-latest, windows-latest]
     steps:
       - uses: actions/checkout@v4

.github/workflows/live-service-testing.yml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
         os: [ubuntu-latest, macos-latest, windows-latest]
     steps:
       - uses: actions/checkout@v4

.github/workflows/testing.yml

@@ -21,7 +21,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
         os: [ubuntu-latest, macos-latest, windows-latest]
     steps:
       - uses: actions/checkout@v4

CHANGELOG.md

@@ -68,6 +68,7 @@
 * The `CEDRecordingInterface` has now been removed; use the `Spike2RecordingInterface` instead. [PR #602](https://github.com/catalystneuro/neuroconv/pull/602)
 
 ### Features
+* Added support for python 3.12 [PR #626](https://github.com/catalystneuro/neuroconv/pull/626)
 * Added `session_start_time` extraction to `FicTracDataInterface`. [PR #598](https://github.com/catalystneuro/neuroconv/pull/598)
 * Added `imaging_plane_name` keyword argument to `add_imaging_plane` function to determine which imaging plane to add from the metadata by name instead of `imaging_plane_index`.
 * Added reference for `imaging_plane` to default plane segmentation metadata. [PR #594](https://github.com/catalystneuro/neuroconv/pull/594)

requirements-minimal.txt

@@ -1,4 +1,5 @@
-numpy>=1.22.0
+numpy>=1.22.0; python_version<='3.11'
+numpy>=1.26.0; python_version>='3.12'
 jsonschema>=3.2.0
 PyYAML>=5.4
 scipy>=1.4.1

src/neuroconv/datainterfaces/ecephys/edf/requirements.txt

@@ -1,2 +1 @@
-pyedflib>=0.1.30
-numpy<1.25.0;python_version>="3.11"
+pyedflib>=0.1.36

src/neuroconv/datainterfaces/ecephys/spike2/spike2datainterface.py

@@ -9,7 +9,7 @@ def _test_sonpy_installation() -> None:
     get_package(
         package_name="sonpy",
         excluded_python_versions=["3.10", "3.11"],
-        excluded_platforms_and_python_versions=dict(darwin=dict(arm=["3.8", "3.9", "3.10", "3.11"])),
+        excluded_platforms_and_python_versions=dict(darwin=dict(arm=["3.8", "3.9", "3.10", "3.11", "3.12"])),
     )
 
 

tests/test_minimal/test_tools/test_backend_and_dataset_configuration/test_models/test_dataset_io_configuration_model.py

@@ -9,7 +9,7 @@
 def test_get_data_io_kwargs_abstract_error():
     with pytest.raises(TypeError) as error_info:
         DatasetIOConfiguration(dataset_info=mock_DatasetInfo(), chunk_shape=(78_125, 64), buffer_shape=(1_250_000, 384))
-    assert "Can't instantiate abstract class DatasetIOConfiguration with abstract" in str(error_info.value)
+    assert "Can't instantiate abstract class DatasetIOConfiguration" in str(error_info.value)
 
 
 def test_get_data_io_kwargs_not_implemented():