Skip to content

Commit

Permalink
Merge pull request #184 from catalystneuro/neuralynx_final_touches
Browse files Browse the repository at this point in the history
Added changelog for neuralynx metadata
  • Loading branch information
CodyCBakerPhD authored Oct 19, 2022
2 parents 8838ef1 + fdc082c commit 068a480
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
### Documentation and tutorial enhancements
* Added a note in User Guide/DataInterfaces to help installing custom dependencies for users who use Z-shell (`zsh`). [PR #180](https://github.com/catalystneuro/neuroconv/pull/180)


### Features
* Added `ConverterPipe`, a class that allows chaining previously intialized interfaces for batch conversion and corresponding tests [PR #169](https://github.com/catalystneuro/neuroconv/pull/169)
* Added automatic extraction of metadata for `NeuralynxRecordingInterface` including filtering information for channels, device and recording time information [PR #170](https://github.com/catalystneuro/neuroconv/pull/170)
* Added stubbing capabilities to timestamp extraction in the `MovieInterface` avoiding scanning through the whole file when `stub_test=True` [PR #181](https://github.com/catalystneuro/neuroconv/pull/181)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,6 @@ class NeuralynxRecordingInterface(BaseRecordingExtractorInterface):

def __init__(self, folder_path: FolderPathType, verbose: bool = True):
super().__init__(folder_path=folder_path, verbose=verbose, all_annotations=True)
neo_reader = self.recording_extractor.neo_reader
self.recording_extractor = self.recording_extractor.select_segments(segment_indices=0)
# preserve neo_reader attribute for SelectSegmentRecording
self.recording_extractor.neo_reader = neo_reader

# add annotation listing all filtering related property keys
filtering_properties = []
for key in self.recording_extractor.get_property_keys():
if key.lower().startswith("dsp"):
filtering_properties.append(key)

# convert properties of object dtype (e.g. datetime) and bool as these are not supported by nwb
for key in self.recording_extractor.get_property_keys():
Expand Down Expand Up @@ -135,8 +125,6 @@ def _dict_intersection(dict_list: List) -> Dict:
dict:
Dictionary containing key-value pairs common to all input dicitionary_list
"""
if len(dict_list) == 0:
return {}

# Collect keys appearing in all dictionaries
common_keys = list(set.intersection(*[set(h.keys()) for h in dict_list]))
Expand Down

0 comments on commit 068a480

Please sign in to comment.