Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session ID for automatic upload #11

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fix session ID for automatic upload #11

merged 2 commits into from
Dec 18, 2023

Conversation

CodyCBakerPhD
Copy link
Member

Automatic upload function automatically adjusts filename to always include session ID, which dandi organize only does when there's more than one session per subject (which we hadn't previously seen in initially shared data)

In this instance, it also depends on the uniqueness of the data_dir_path, which we can't see on the entire MIT side

I can eventually fix the helper in NeuroConv around this condition, but for now this should fix it

Will have to consider if including ses- in nwbfile.session_id is against best practice or not... strictly speaking the DANDI convention is to name file as ..._ses-{session_id}_... so it would be weird to also have ses- in the session ID itself (source of issue here)

@CodyCBakerPhD CodyCBakerPhD self-assigned this Dec 18, 2023
@CodyCBakerPhD
Copy link
Member Author

@nwatters01 Also let me know if you want to modify this field in the already existing NWB files instead of reconverting them

@CodyCBakerPhD CodyCBakerPhD merged commit 3557448 into main Dec 18, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the fix_session_id branch December 18, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants