Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keypoint Conversion #85

Merged
merged 19 commits into from
Oct 31, 2023
Merged

Keypoint Conversion #85

merged 19 commits into from
Oct 31, 2023

Conversation

pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Oct 13, 2023 •
edited
Loading

Adds support for keypoint data with associated raw photometry and IR videos.

@pauladkisson pauladkisson marked this pull request as draft October 13, 2023 21:07
@pauladkisson pauladkisson marked this pull request as ready for review October 16, 2023 23:25
@CodyCBakerPhD
Copy link
Member

Small comment on convention above

Otherwise code seems fine

Let me know when an example file is ready for perusal

@pauladkisson
Copy link
Member Author

Let me know when an example file is ready for perusal

example file is uploaded!

@CodyCBakerPhD
Copy link
Member

example file is uploaded!

Can you point me to a particular example file there for this PR?

@pauladkisson
Copy link
Member Author

Can you point me to a particular example file there for this PR?

keypoint-dls-dlight-9

@CodyCBakerPhD
Copy link
Member

Thanks

A lot of the keypoints have spaces in the names, which for programmatic access to the dictionaries is not recommended; can you pragmatically replaces spaces with underscores? This would also make it more similar to other keypoint trackers like SLEAP and DLC

@CodyCBakerPhD
Copy link
Member

Otherwise the dataset contents all look good for pose estimation work

@pauladkisson
Copy link
Member Author

pauladkisson commented Oct 30, 2023 •
edited
Loading

A lot of the keypoints have spaces in the names, which for programmatic access to the dictionaries is not recommended; can you pragmatically replaces spaces with underscores? This would also make it more similar to other keypoint trackers like SLEAP and DLC

Done! And see updated example file: keypoint-dls-dlight-9.nwb.

@CodyCBakerPhD CodyCBakerPhD merged commit abee15f into main Oct 31, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the keypoint branch October 31, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodyCBakerPhD CodyCBakerPhD CodyCBakerPhD approved these changes

Assignees

@pauladkisson pauladkisson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauladkisson @CodyCBakerPhD