Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed nwbconverters to avoid ambiguity #84

Merged
merged 2 commits into from
Oct 13, 2023
Merged

renamed nwbconverters to avoid ambiguity #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48577e1
renamed nwbconverters to avoid ambiguity
pauladkisson Oct 9, 2023
60467f1
Merge branch 'main' into rename_nwbconverters
pauladkisson Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frozen_dependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ natsort==8.4.0
nbclient==0.8.0
nbconvert==7.7.3
nbformat==5.9.2
-e git+https://github.com/pauladkisson/ndx-moseq.git@2c25aaa85bb70762111a520918c73abac4ac0801#egg=ndx_depth_moseq
# Editable install with no version control (ndx-depth-moseq==0.1.0)
-e /opt/anaconda3/envs/datta_env/lib/python3.10/site-packages
ndx-events==0.2.0
ndx-grayscalevolume==0.0.2
ndx-icephys-meta==0.1.0
Expand Down
4 changes: 2 additions & 2 deletions src/datta_lab_to_nwb/markowitz_gillis_nature_2023/convert_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

# Local
from datta_lab_to_nwb.markowitz_gillis_nature_2023.postconversion import reproduce_fig1d
from datta_lab_to_nwb import markowitz_gillis_nature_2023
from datta_lab_to_nwb.markowitz_gillis_nature_2023.nwbconverter import DattaNWBConverter


def session_to_nwb(
Expand Down Expand Up @@ -114,7 +114,7 @@ def session_to_nwb(
if experiment_type == "velocity-modulation":
conversion_options["BehavioralSyllable"] = dict(velocity_modulation=True)

converter = markowitz_gillis_nature_2023.NWBConverter(source_data=source_data)
converter = DattaNWBConverter(source_data=source_data)
metadata = converter.get_metadata()

# Update metadata
Expand Down
2 changes: 1 addition & 1 deletion src/datta_lab_to_nwb/markowitz_gillis_nature_2023/nwbconverter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from .irvideointerface import IRVideoInterface


class NWBConverter(NWBConverter):
class DattaNWBConverter(NWBConverter):
"""Primary conversion class."""

data_interface_classes = dict(
Expand Down
4 changes: 2 additions & 2 deletions src/datta_lab_to_nwb/markowitz_gillis_nature_2023_HEK/convert_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from pathlib import Path
from typing import Union
from neuroconv.utils import dict_deep_update, load_dict_from_file
from datta_lab_to_nwb import markowitz_gillis_nature_2023_HEK
from datta_lab_to_nwb.markowitz_gillis_nature_2023_HEK.nwbconverter import DattaHEKNWBConverter
import shutil
from pynwb import NWBHDF5IO
from datta_lab_to_nwb.markowitz_gillis_nature_2023_HEK.postconversion import reproduce_figS1abcd
Expand All @@ -28,7 +28,7 @@ def session_to_nwb(
conversion_options = {
"HEK": dict(),
}
converter = markowitz_gillis_nature_2023_HEK.NWBConverter(source_data=source_data)
converter = DattaHEKNWBConverter(source_data=source_data)
metadata = converter.get_metadata()

# Update metadata
Expand Down
2 changes: 1 addition & 1 deletion src/datta_lab_to_nwb/markowitz_gillis_nature_2023_HEK/nwbconverter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from .hekinterface import HEKInterface


class NWBConverter(NWBConverter):
class DattaHEKNWBConverter(NWBConverter):
"""Primary conversion class."""

data_interface_classes = dict(
Expand Down