Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix names and add exclusion to mapping #59

Merged
merged 21 commits into from
Aug 26, 2024
Merged

Fix names and add exclusion to mapping #59

merged 21 commits into from
Aug 26, 2024

Conversation

CodyCBakerPhD
Copy link
Member

Minor fixes to variable names and argument structures for mapping (mainly exclusion for 000108)

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 26, 2024
@CodyCBakerPhD CodyCBakerPhD merged commit 4895c32 into main Aug 26, 2024
3 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix_names branch August 26, 2024 05:33
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.79%. Comparing base (5244c4c) to head (1a65f49).
Report is 1 commits behind head on main.

Files Patch % Lines
src/dandi_s3_log_parser/_command_line_interface.py 0.00% 3 Missing ⚠️
..._s3_log_parser/_map_binned_s3_logs_to_dandisets.py 91.42% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   65.45%   64.79%   -0.67%     
==========================================
  Files          14       14              
  Lines         579      588       +9     
==========================================
+ Hits          379      381       +2     
- Misses        200      207       +7     
Flag Coverage Δ
unittests 64.79% <84.21%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dandi_s3_log_parser/_command_line_interface.py 0.00% <0.00%> (ø)
..._s3_log_parser/_map_binned_s3_logs_to_dandisets.py 93.24% <91.42%> (-3.78%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant