Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to mapping #57

Merged
merged 13 commits into from
Aug 23, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Member

New prototype files were getting a bit large so breaking them up per dandifile for easier sharing and lookup; with a summary file present for each dandiset version with accumulated (binned daily) content

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 22, 2024
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 23, 2024 03:37
@CodyCBakerPhD CodyCBakerPhD merged commit 05a1d0c into main Aug 23, 2024
3 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the add_mapping_option_for_object_type branch August 23, 2024 03:37
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.45%. Comparing base (9795ca5) to head (797820c).
Report is 10 commits behind head on main.

Files Patch % Lines
src/dandi_s3_log_parser/_command_line_interface.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   64.34%   65.45%   +1.10%     
==========================================
  Files          14       14              
  Lines         561      579      +18     
==========================================
+ Hits          361      379      +18     
  Misses        200      200              
Flag Coverage Δ
unittests 65.45% <94.44%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...g_parser/_bin_all_reduced_s3_logs_by_object_key.py 84.44% <ø> (ø)
..._s3_log_parser/_map_binned_s3_logs_to_dandisets.py 97.01% <100.00%> (+0.93%) ⬆️
src/dandi_s3_log_parser/_command_line_interface.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant