Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-meeting fixes 1 #50

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Post-meeting fixes 1 #50

merged 6 commits into from
Aug 16, 2024

Conversation

CodyCBakerPhD
Copy link
Member

@CodyCBakerPhD CodyCBakerPhD commented Aug 16, 2024

fix #49 and #46

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 16, 2024
@CodyCBakerPhD CodyCBakerPhD linked an issue Aug 16, 2024 that may be closed by this pull request
CodyCBakerPhD added 2 commits August 16, 2024 14:43
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 16, 2024 19:08
@CodyCBakerPhD CodyCBakerPhD merged commit 683c281 into main Aug 16, 2024
3 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the nest_reduced branch August 16, 2024 19:16
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.52%. Comparing base (a00b580) to head (a5862cc).
Report is 2 commits behind head on main.

Files Patch % Lines
.../dandi_s3_log_parser/_dandi_s3_log_file_reducer.py 84.61% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   65.08%   65.52%   +0.44%     
==========================================
  Files          12       12              
  Lines         484      496      +12     
==========================================
+ Hits          315      325      +10     
- Misses        169      171       +2     
Flag Coverage Δ
unittests 65.52% <94.28%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dandi_s3_log_parser/_dandiset_mapper.py 95.83% <100.00%> (+0.27%) ⬆️
src/dandi_s3_log_parser/_s3_log_file_reducer.py 100.00% <100.00%> (ø)
.../dandi_s3_log_parser/_dandi_s3_log_file_reducer.py 79.78% <84.61%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nest reduced s3 logs like they are on s3 bucket .temp not cleaned up in demo
1 participant