Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final debugs and polish #45

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Final debugs and polish #45

merged 8 commits into from
Aug 16, 2024

Conversation

CodyCBakerPhD
Copy link
Member

Before next release

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 16, 2024
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 16, 2024 15:10
@CodyCBakerPhD CodyCBakerPhD merged commit a2b19d2 into main Aug 16, 2024
2 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fixes branch August 16, 2024 15:10
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.93%. Comparing base (a00b580) to head (aac39d1).
Report is 1 commits behind head on main.

Files Patch % Lines
src/dandi_s3_log_parser/_command_line_interface.py 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   65.08%   64.93%   -0.15%     
==========================================
  Files          12       12              
  Lines         484      482       -2     
==========================================
- Hits          315      313       -2     
  Misses        169      169              
Flag Coverage Δ
unittests 64.93% <88.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dandi_s3_log_parser/__init__.py 100.00% <100.00%> (ø)
.../dandi_s3_log_parser/_dandi_s3_log_file_reducer.py 80.45% <100.00%> (ø)
src/dandi_s3_log_parser/_dandiset_mapper.py 95.65% <100.00%> (+0.09%) ⬆️
src/dandi_s3_log_parser/_s3_log_file_reducer.py 100.00% <100.00%> (ø)
src/dandi_s3_log_parser/_s3_log_line_parser.py 76.13% <ø> (ø)
src/dandi_s3_log_parser/_command_line_interface.py 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant