Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better convenience #36

Merged
merged 19 commits into from
Aug 14, 2024
Merged

Better convenience #36

merged 19 commits into from
Aug 14, 2024

Conversation

CodyCBakerPhD
Copy link
Member

Various quality of life improvements and some validation debugs

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 71.79487% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.93%. Comparing base (b86be2f) to head (6e0c20a).

Files Patch % Lines
src/dandi_s3_log_parser/_s3_log_line_parser.py 57.89% 8 Missing ⚠️
...c/dandi_s3_log_parser/_dandi_s3_log_file_parser.py 86.66% 2 Missing ⚠️
src/dandi_s3_log_parser/_command_line_interface.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   67.89%   67.93%   +0.04%     
==========================================
  Files          11       11              
  Lines         408      421      +13     
==========================================
+ Hits          277      286       +9     
- Misses        131      135       +4     
Flag Coverage Δ
unittests 67.93% <71.79%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dandi_s3_log_parser/_s3_log_file_parser.py 100.00% <100.00%> (ø)
src/dandi_s3_log_parser/_command_line_interface.py 0.00% <0.00%> (ø)
...c/dandi_s3_log_parser/_dandi_s3_log_file_parser.py 81.11% <86.66%> (ø)
src/dandi_s3_log_parser/_s3_log_line_parser.py 80.61% <57.89%> (-1.42%) ⬇️

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 14, 2024 15:34
@CodyCBakerPhD CodyCBakerPhD merged commit 93cec44 into main Aug 14, 2024
2 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the convenience branch August 14, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant