Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory overhead per worker #35

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Reduce memory overhead per worker #35

merged 2 commits into from
Aug 14, 2024

Conversation

CodyCBakerPhD
Copy link
Member

During recent stress testing with parallelization, workers kept causing broken processes in the pool by using too much memory, even with relatively low buffer maximums set

Here are some further optimizations to minimize the memory overhead required per worker

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 80.30303% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base (0b1e03a) to head (53c5353).
Report is 4 commits behind head on main.

Files Patch % Lines
src/dandi_s3_log_parser/_s3_log_line_parser.py 71.42% 12 Missing ⚠️
...c/dandi_s3_log_parser/_dandi_s3_log_file_parser.py 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   72.37%   67.89%   -4.48%     
==========================================
  Files          11       11              
  Lines         409      408       -1     
==========================================
- Hits          296      277      -19     
- Misses        113      131      +18     
Flag Coverage Δ
unittests 67.89% <80.30%> (-4.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dandi_s3_log_parser/_s3_log_file_parser.py 100.00% <100.00%> (+2.04%) ⬆️
...c/dandi_s3_log_parser/_dandi_s3_log_file_parser.py 81.11% <87.50%> (+0.11%) ⬆️
src/dandi_s3_log_parser/_s3_log_line_parser.py 82.02% <71.42%> (-6.71%) ⬇️

... and 1 file with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 14, 2024 04:51
@CodyCBakerPhD CodyCBakerPhD merged commit b86be2f into main Aug 14, 2024
2 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the reduce_memory branch August 14, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant