Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override cpu limit #34

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Override cpu limit #34

merged 3 commits into from
Aug 14, 2024

Conversation

CodyCBakerPhD
Copy link
Member

Doing some research, for an I/O bound (or at least reliant) task like we have, using more workers than CPU can still grant significant speedups

So overriding the previous limits here

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (0b1e03a) to head (f42369e).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   72.37%   72.22%   -0.15%     
==========================================
  Files          11       11              
  Lines         409      414       +5     
==========================================
+ Hits          296      299       +3     
- Misses        113      115       +2     
Flag Coverage Δ
unittests 72.22% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dandi_s3_log_parser/_command_line_interface.py 0.00% <ø> (ø)
...c/dandi_s3_log_parser/_dandi_s3_log_file_parser.py 81.00% <ø> (ø)

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 14, 2024 04:40
@CodyCBakerPhD CodyCBakerPhD merged commit ee06156 into main Aug 14, 2024
2 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the override_cpu_limits branch August 14, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant