Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include line index in reduced log type #33

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Member

Add line index to parser for easier lookup in source data; a future addition will be the helper that 'looks up' the raw line from the base folder given the reduced line

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (0b1e03a) to head (487592b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   72.37%   72.22%   -0.15%     
==========================================
  Files          11       11              
  Lines         409      414       +5     
==========================================
+ Hits          296      299       +3     
- Misses        113      115       +2     
Flag Coverage Δ
unittests 72.22% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dandi_s3_log_parser/_s3_log_file_parser.py 98.03% <100.00%> (+0.08%) ⬆️
src/dandi_s3_log_parser/_s3_log_line_parser.py 88.73% <100.00%> (ø)

@CodyCBakerPhD CodyCBakerPhD changed the title Include line index in reduce log type Include line index in reduced log type Aug 13, 2024
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 13, 2024 18:53
@CodyCBakerPhD CodyCBakerPhD merged commit 19ac9ac into main Aug 13, 2024
2 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the reduce_memory branch August 13, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant