Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure process #29

Merged
merged 11 commits into from
Aug 12, 2024
Merged

Restructure process #29

merged 11 commits into from
Aug 12, 2024

Conversation

CodyCBakerPhD
Copy link
Member

Encountering some minor issues during new full run and realized current process was not as simple or broken up as it could be

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 79.48718% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.30%. Comparing base (4c9cb30) to head (0248b77).

Files Patch % Lines
src/dandi_s3_log_parser/_command_line_interface.py 0.00% 6 Missing ⚠️
src/dandi_s3_log_parser/_s3_log_line_parser.py 50.00% 4 Missing ⚠️
...c/dandi_s3_log_parser/_dandi_s3_log_file_parser.py 90.00% 2 Missing ⚠️
src/dandi_s3_log_parser/_ip_utils.py 85.71% 2 Missing ⚠️
src/dandi_s3_log_parser/_config.py 50.00% 1 Missing ⚠️
src/dandi_s3_log_parser/testing/_helpers.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   75.05%   72.30%   -2.76%     
==========================================
  Files          11       11              
  Lines         449      408      -41     
==========================================
- Hits          337      295      -42     
- Misses        112      113       +1     
Flag Coverage Δ
unittests 72.30% <79.48%> (-2.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dandi_s3_log_parser/__init__.py 100.00% <100.00%> (ø)
src/dandi_s3_log_parser/_buffered_text_reader.py 97.05% <100.00%> (+0.18%) ⬆️
..._s3_log_parser/_order_and_anonymize_parsed_logs.py 100.00% <100.00%> (ø)
src/dandi_s3_log_parser/_s3_log_file_parser.py 97.95% <100.00%> (-0.58%) ⬇️
src/dandi_s3_log_parser/_config.py 68.42% <50.00%> (ø)
src/dandi_s3_log_parser/testing/_helpers.py 0.00% <0.00%> (ø)
...c/dandi_s3_log_parser/_dandi_s3_log_file_parser.py 80.80% <90.00%> (-0.94%) ⬇️
src/dandi_s3_log_parser/_ip_utils.py 87.80% <85.71%> (-12.20%) ⬇️
src/dandi_s3_log_parser/_s3_log_line_parser.py 88.73% <50.00%> (-0.31%) ⬇️
src/dandi_s3_log_parser/_command_line_interface.py 0.00% <0.00%> (ø)

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 12, 2024 16:36
@CodyCBakerPhD CodyCBakerPhD merged commit 98c26a4 into main Aug 12, 2024
2 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the delay_ip_to_region branch August 12, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant