Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve argument names #23

Merged
merged 4 commits into from
Aug 11, 2024
Merged

Improve argument names #23

merged 4 commits into from
Aug 11, 2024

Conversation

CodyCBakerPhD
Copy link
Member

Various reorganizations, renames, and improvements

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 11, 2024
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 11, 2024 17:03
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) August 11, 2024 17:03
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 20 lines in your changes missing coverage. Please review.

Project coverage is 65.58%. Comparing base (b86d789) to head (c8018c2).
Report is 2 commits behind head on main.

Files Patch % Lines
...c/dandi_s3_log_parser/_dandi_s3_log_file_parser.py 81.18% 19 Missing ⚠️
src/dandi_s3_log_parser/_command_line_interface.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   60.23%   65.58%   +5.35%     
==========================================
  Files           9       11       +2     
  Lines         337      433      +96     
==========================================
+ Hits          203      284      +81     
- Misses        134      149      +15     
Flag Coverage Δ
unittests 65.58% <81.48%> (+5.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dandi_s3_log_parser/__init__.py 100.00% <100.00%> (ø)
src/dandi_s3_log_parser/_buffered_text_reader.py 96.55% <100.00%> (ø)
src/dandi_s3_log_parser/_s3_log_file_parser.py 97.14% <ø> (+19.96%) ⬆️
src/dandi_s3_log_parser/_s3_log_line_parser.py 71.18% <100.00%> (ø)
src/dandi_s3_log_parser/_command_line_interface.py 0.00% <0.00%> (ø)
...c/dandi_s3_log_parser/_dandi_s3_log_file_parser.py 81.18% <81.18%> (ø)

... and 1 file with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD disabled auto-merge August 11, 2024 17:09
@CodyCBakerPhD CodyCBakerPhD merged commit 7d6c789 into main Aug 11, 2024
2 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the organization branch August 11, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant