Issue #228: Fix remote column missing in schema check #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keevan
reviewed
Dec 20, 2022
There was a problem hiding this comment.
Looks mostly good. Some indentation tweaks and a version change required.
In terms of impact, this shouldn't impact existing sites without the missing remote column issue, as it will skip adding the field if it already exists. This upgrade is to fix sites which were in a bad state.
jnlar
force-pushed
the
issue228-column-remote-missing
branch
from
b72c284
to
d669852
Compare
keevan
reviewed
Dec 20, 2022
jnlar
force-pushed
the
issue228-column-remote-missing
branch
from
d669852
to
28ad15b
Compare
jnlar
force-pushed
the
issue228-column-remote-missing
branch
from
28ad15b
to
0cae6df
Compare
keevan
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream issue: jleyva#228
Version bumping the remote column update as well as the plugin version in version.php