cleanup the excel extractor to no longer look for a single file #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmgosnell
commented
Dec 29, 2023
Comment on lines
408
to
411
| def get_zipfile_resource(self, dataset: str, **filters: Any) -> zipfile.ZipFile: | ||
| """Retrieves unique resource and opens it as a ZipFile.""" | ||
| # TODO: add some check if the result of get_unique_resource isn't a zip file. | ||
| return zipfile.ZipFile(io.BytesIO(self.get_unique_resource(dataset, **filters))) |
There was a problem hiding this comment.
hey @rousik ! since the excel extractor no longer needs to deal with a single file in the case of eia860m and can always expect a zipped resource, I stripped out that possibility from the excel extractor. But i thought it might be good to have a very clear message to let you know if you somehow are pointing to a non-zipped resource. Do you know of an easy way to check for that? also, this may be a moot question bc maybe the error message that would result from this would be clear enough.
|
closing bc maybe we want this functionality in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What problem does this address?
In #3189 we started to use a eia860m archive with zipped files instead of stand xlsx files. which means that we can remove some cruft that handled this in the excel extractor.
What did you change?
I mostly just removed the option for an archive to go grab an individual file. now it always looks for a zipped resource
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list