Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTONLY Import faster xbrl #3199

Closed
wants to merge 3 commits into from
Closed

TESTONLY Import faster xbrl #3199

wants to merge 3 commits into from

Conversation

rousik
Copy link
Collaborator

@rousik rousik commented Dec 29, 2023

This attempts to import ferc-xbrl-extractor directly from github and from specific branch to test the changes. Once ci-integration is run, we could assess the speed up of this.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (b8fa2b5) 92.6% compared to head (1fd311d) 92.6%.
Report is 133 commits behind head on main.

Files Patch % Lines
...rc/pudl/analysis/record_linkage/link_cross_year.py 88.7% 12 Missing ⚠️
src/pudl/analysis/record_linkage/name_cleaner.py 85.9% 12 Missing ⚠️
test/integration/record_linkage_test.py 95.8% 3 Missing ⚠️
...l/analysis/record_linkage/classify_plants_ferc1.py 92.9% 2 Missing ⚠️
...rc/pudl/analysis/record_linkage/embed_dataframe.py 98.6% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3199     +/-   ##
=======================================
- Coverage   92.6%   92.6%   -0.0%     
=======================================
  Files        134     140      +6     
  Lines      12611   12841    +230     
=======================================
+ Hits       11682   11894    +212     
- Misses       929     947     +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rousik rousik closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant