-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to sync a local directory up to a Zenodo DOI #3127
Conversation
89a1fbc
to
8eda506
Compare
2aa371c
to
e6348b7
Compare
So you should be able to use this script to sync a local directory up to a Zenodo DOI - and it will leave a draft for you to manually approve, or just YOLO it and publish (with the I think this functionality is useful enough to merge into
I wonder if that is enough funkiness to warrant moving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly questions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3127 +/- ##
=====================================
Coverage 92.7% 92.7%
=====================================
Files 134 134
Lines 12597 12597
=====================================
+ Hits 11672 11673 +1
+ Misses 925 924 -1 ☔ View full report in Codecov by Sentry. |
2bc73e4
to
b8b4fc6
Compare
Notes on attempted use:
./zenodo_data_release.py --env sandbox --concept-rec-id 5563 --no-publish --source-dir ../../../no-backups/nightly and got the following error:
./zenodo_data_release.py --env sandbox --no-publish ../../../no-backups/nightly
|
Thanks for the digging, I would have definitely gotten confused by the bucket API thing! Here's my TODO list for fixes: TODO
|
d394f80
to
7c4f107
Compare
I do generally prefer "keyword" vs. "positional" arguments because they are much harder to misuse - so keeping that in for now. The Whole Dang Nightly Builds Output also made it to Sandbox! With the following command:
And took about 2 hours, 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some clarifications on the help messages, and would like to know what you think about embedding the target record IDs in the script, at least as defaults.
✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly, this became a PR where I wrote the code and Zane was reviewing. But he made a ✅ so I'm making the official GH PR-approval.
@jdangerx Will the auto-merge go through if the branch is out of date with the base branch? I feel like several PRs of mine have gotten stuck lately because of this. |
I think it will work if and only if the PR is still "auto-mergeable" / there are no conflicts. We'll see! |
Looks like the answer, from another PR, is "no." So I'm gonna click that 'update branch' button. |
Co-authored-by: Zane Selvans <[email protected]>
87e1a8d
to
8e88c26
Compare
PR Overview
Just struggling with the Zenodo API for the moment. Can easily do a manual upload of the files as well.
PR Checklist
dev
).