Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot fix cliffside capacity #3046

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Spot fix cliffside capacity #3046

merged 5 commits into from
Nov 16, 2023

Conversation

cmgosnell
Copy link
Member

@cmgosnell cmgosnell commented Nov 14, 2023

PR Overview

@jrea-rmi and Andrew (don't know your @!) found a x100 error in capacity for 2021. it jumped back in 2022. So i added a small spot fix.

the data entry error:

image

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zaneselvans
Copy link
Member

Hey @cmgosnell it seems like this should be pointed at dev rather than main but when I try to change the target branch, it says there are no new commits.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c49a3b) 88.7% compared to head (f5677a1) 88.7%.
Report is 11 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3046   +/-   ##
=====================================
  Coverage   88.7%   88.7%           
=====================================
  Files         90      90           
  Lines      10994   10994           
=====================================
  Hits        9758    9758           
  Misses      1236    1236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmgosnell
Copy link
Member Author

@zaneselvans ha! this is what i get for trying to make a pr at a conference! new little commit on the way

@cmgosnell cmgosnell changed the base branch from main to dev November 15, 2023 20:19
@zaneselvans zaneselvans merged commit 1000187 into dev Nov 16, 2023
11 checks passed
@zaneselvans zaneselvans deleted the spot-fix-cliffside-capacity branch November 16, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants