Always use tmp path for clobber tests. #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendnorman
approved these changes
Nov 13, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3043 +/- ##
=====================================
Coverage 88.7% 88.7%
=====================================
Files 90 90
Lines 10994 10994
=====================================
Hits 9758 9758
Misses 1236 1236 ☔ View full report in Codecov by Sentry. |
bendnorman
reviewed
Nov 14, 2023
| @@ -122,7 +130,7 @@ def test_xbrl2sqlite(settings, forms, mocker): | |||
| form, | |||
| mock_datastore, | |||
| output_path=PudlPaths().output_dir, | |||
| sql_path=PudlPaths().output_dir / f"ferc{form.value}_xbrl.sqlite", | |||
| sql_path=tmp_path / f"ferc{form.value}_xbrl.sqlite", | |||
There was a problem hiding this comment.
Why do you need to mock PudlPaths if you're using tmp_path here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests running with
--live-dbsactually clobbered the XBRL databases - so we'd generate them, run ETL based on them, and then clobber them in nightly build before we got to actually upload to GCS.