Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lockfile #3022

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Update Lockfile #3022

merged 1 commit into from
Nov 7, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 7, 2023

This pull request relocks the dependencies with conda-lock. It is triggered by update-lockfile.

@github-actions github-actions bot added conda-lock dependencies Pull requests that update a dependency file labels Nov 7, 2023
@github-actions github-actions bot requested a review from zaneselvans November 7, 2023 15:16
@zaneselvans zaneselvans marked this pull request as ready for review November 7, 2023 15:38
@zaneselvans
Copy link
Member

This was just a test of the workflow_dispatch behavior, which seems to work fine! Which is good because it's the same behavior as the schedule triggers.

@zaneselvans
Copy link
Member

zaneselvans commented Nov 7, 2023

Hmm. Why isn't docker-build-test running as a check here? It's supposed to be triggered on pull_request which by default includes the creation event type but it didn't kick off here. Do you see anything obvious that would prevent it from being run here @jdangerx @bendnorman ?

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a886635) 88.6% compared to head (aa13a5f) 88.7%.
Report is 60 commits behind head on conda-lockfile.

Additional details and impacted files
@@              Coverage Diff               @@
##           conda-lockfile   #3022   +/-   ##
==============================================
  Coverage            88.6%   88.7%           
==============================================
  Files                  91      91           
  Lines               10991   11010   +19     
==============================================
+ Hits                 9749    9768   +19     
  Misses               1242    1242           
Files Coverage Δ
src/pudl/analysis/allocate_gen_fuel.py 91.3% <ø> (ø)
src/pudl/etl/glue_assets.py 98.2% <ø> (ø)
src/pudl/extract/eia923.py 100.0% <100.0%> (ø)
src/pudl/extract/excel.py 96.3% <100.0%> (-0.5%) ⬇️
src/pudl/metadata/classes.py 86.5% <100.0%> (+<0.1%) ⬆️
src/pudl/metadata/constants.py 100.0% <ø> (ø)
src/pudl/metadata/fields.py 100.0% <ø> (ø)
src/pudl/metadata/resources/eia.py 100.0% <ø> (ø)
src/pudl/metadata/resources/eia923.py 100.0% <ø> (ø)
src/pudl/metadata/sources.py 100.0% <ø> (ø)
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaneselvans zaneselvans merged commit 5fc9d43 into conda-lockfile Nov 7, 2023
9 checks passed
@zaneselvans zaneselvans deleted the update-conda-lockfile branch November 7, 2023 17:27
@bendnorman
Copy link
Member

Hmm seems strange the tox-pytest workflows ran on pull_request but the docker-build-test. Do you think it has something to do with github's policy about triggering workflows using GITHUB_TOKEN:
https://github.com/catalyst-cooperative/pudl/blob/ce1b983b8242e8ee6d684a788804518851392049/.github/workflows/update-lockfile.yml#L41C1-L48C48

@zaneselvans
Copy link
Member

That policy is why I'm using a @pudlbot PAT rather than the generic GITHUB_TOKEN in the checkout. to get all the tests to retrigger. Maybe I need to use that in the step that makes the new PR?

@zaneselvans
Copy link
Member

But yeah, why did it trigger some of the tests and not others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda-lock dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants