Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip integraton tests on draft PRs #2839

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Skip integraton tests on draft PRs #2839

merged 1 commit into from
Sep 9, 2023

Conversation

jdangerx
Copy link
Member

@jdangerx jdangerx commented Sep 8, 2023

To save time/energy/$, we can only run the long CI jobs on PRs that are nominally ready for review.

Testing plan:

  • make this a draft PR, and see if ci-integration runs
  • turn this into a non-draft PR, and see if ci-integration runs

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jdangerx jdangerx changed the base branch from main to dev September 8, 2023 13:20
@jdangerx jdangerx marked this pull request as ready for review September 8, 2023 13:21
@jdangerx jdangerx marked this pull request as draft September 8, 2023 13:22
@jdangerx jdangerx marked this pull request as ready for review September 8, 2023 16:09
@jdangerx
Copy link
Member Author

jdangerx commented Sep 8, 2023

Boo, it doesn't re-run once you switch to ready-for-review. Need to look into that a bit more.

@jdangerx jdangerx marked this pull request as draft September 8, 2023 16:41
@jdangerx jdangerx marked this pull request as ready for review September 8, 2023 16:43
@jdangerx jdangerx marked this pull request as draft September 8, 2023 16:43
@jdangerx jdangerx force-pushed the ci-skipdraft branch 4 times, most recently from ccae1f0 to 2696b94 Compare September 8, 2023 16:49
@@ -1,7 +1,13 @@
---
name: tox-pytest

on: [pull_request]
on:
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might we want to add a workflow_dispatch here so someone can manually kick off the integration tests once without needing to change the status of the PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. I'm not sure how the workflow_dispatch event will interact with the if: expression, since then presumably pull_request.event won't be defined.

I'm inclined to keep this change as-is and not deal with that, since it's pretty easy to change the status of the PR to get integration tests running if one wants them.

@jdangerx jdangerx marked this pull request as ready for review September 8, 2023 22:01
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (da51425) 88.5% compared to head (b3567e5) 88.5%.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2839   +/-   ##
=====================================
  Coverage   88.5%   88.5%           
=====================================
  Files         90      90           
  Lines      10134   10134           
=====================================
  Hits        8978    8978           
  Misses      1156    1156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaneselvans zaneselvans merged commit 86ece0c into dev Sep 9, 2023
@zaneselvans zaneselvans deleted the ci-skipdraft branch September 9, 2023 15:17
@bendnorman
Copy link
Member

This is great thanks @jdangerx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants