-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip integraton tests on draft PRs #2839
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Boo, it doesn't re-run once you switch to ready-for-review. Need to look into that a bit more. |
f48f085
to
f705587
Compare
f705587
to
e8c768a
Compare
ccae1f0
to
2696b94
Compare
2696b94
to
b3567e5
Compare
@@ -1,7 +1,13 @@ | |||
--- | |||
name: tox-pytest | |||
|
|||
on: [pull_request] | |||
on: | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might we want to add a workflow_dispatch
here so someone can manually kick off the integration tests once without needing to change the status of the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. I'm not sure how the workflow_dispatch event will interact with the if:
expression, since then presumably pull_request.event
won't be defined.
I'm inclined to keep this change as-is and not deal with that, since it's pretty easy to change the status of the PR to get integration tests running if one wants them.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## dev #2839 +/- ##
=====================================
Coverage 88.5% 88.5%
=====================================
Files 90 90
Lines 10134 10134
=====================================
Hits 8978 8978
Misses 1156 1156 ☔ View full report in Codecov by Sentry. |
This is great thanks @jdangerx ! |
To save time/energy/$, we can only run the long CI jobs on PRs that are nominally ready for review.
Testing plan: