Refine redmine_hearts:migrate_from_vote_on_issues task (for master) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is cherry-picked from cat-in-136@8d81c70 .
… is not supported
This commit is cherry-picked from cat-in-136@fd0f143 .
…round for older versions to the github workflow This commit is cherry-picked from cat-in-136@9ecf6e3 .
This commit is cherry-picked from cat-in-136@c1592b6 .
…[email protected] to run on node20 This commit is cherry-picked from cat-in-136@5ad0e66 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51 is precedes this pull-request. This pull-request's changes are e0d2189 and 786b05f .
CI result is here: https://github.com/nishidayuya/redmine_hearts/actions/runs/11682722316
About e0d2189
Sometimes,
vote_on_issuestable has noissue_idrecords. Becausevote_on_issues.issue_iddoes not have NOT NULL constraint (NULL-able).vote_on_issues.issue_idditto.So, I want to skip invalid records when migrating from
vote_on_issues. I create this commit.About 786b05f
My environment has
vote_on_issuesrecords by locked users. Because I want to migrate them, I create this commit.I think another solution that is skipping migration for records by locked users. But I want to do data migration as many as possible.