Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Redmine6/rails7 #50

Merged
merged 17 commits into from
Dec 1, 2024
Merged

Support for Redmine6/rails7 #50

merged 17 commits into from
Dec 1, 2024

Conversation

cat-in-136
Copy link
Owner

@cat-in-136 cat-in-136 commented Aug 3, 2024 •
edited
Loading

  1. Update Redmine/Ruby Versions in Workflows:

    • Updated the Redmine/Redmica/Ruby versions in the GitHub workflows to the latest stable releases.
    • Added new matrix environments for testing.

  2. Ignore unloadable if Method Missing:

    • Modified the unloadable declaration in several models and controllers to conditionally check if the method is defined.

  3. Use ApplicationRecord Instead of ActiveRecord::Base:

    • Refactored models to inherit from ApplicationRecord if available, ensuring compatibility with Rails7.

  4. Workaround for LoadError:

    • Added a workaround in the GitHub workflow to handle the LoadError: cannot load such file -- blankslate issue for older versions.

  5. Drop Support for Redmine 4.0 and 4.1:

    • Removed references and support for Redmine versions 4.0 and 4.1 from the workflows.

  6. Introduce Tabler Icons for Redmine 6.0:

    • Added new SVG icons and updated views to utilize the new icon set, matching redmine6 user interface.

  7. Update README and init.rb:

    • Specified licenses in the README and updated the Redmine version requirement to 4.2.0. The plugin version has been bumped to 4.0.0.

cat-in-136 added 10 commits August 3, 2024 11:14
@cat-in-136
update redmine versions in the github workflows
8d81c70
@cat-in-136
refactor .github/workflows/redmine_plugin.yml
fd0f143
@cat-in-136
Ignore unloadable if method missing
53e8e3a
@cat-in-136
Use ApplicationRecord instead of ActiveRecord::Base
59f151e 
to follow https://www.redmine.org/issues/38975
@cat-in-136
use :assigns instead of @-starting keys in :locals in render_to_string
a978fbe
@cat-in-136
remove DateTime#to_s(:db) and use DateTime as-is
4b299a0 
Changed because DateTime#to_s(:db) is no longer supported in Rails7
@cat-in-136
add "LoadError: cannot load such file -- blankslate" Issue HACK worka…
9ecf6e3 
…round for older versions to the github workflow
@cat-in-136
drop support redmine 4.0 and 4.1
c1592b6
@cat-in-136
update actions/checkout@v4, actions/cache@v4 and DamianReeves/write-f…
5ad0e66 
…[email protected] to run on node20
@cat-in-136
Fix check condition of script[src]/link[href] test to relaxed path re…
1455710 
…gexp.

Due to the asset pipeline integration using Propshaft introduced in redmine 6 (https://www.redmine.org/issues/39111), the plugin assert file path changes between redmine6 and previous versions. In addition, there is no common API to get the path beyond those versions. This change does not introduce ugly version branching if-else, just relaxed condition regexp.
@nishidayuya nishidayuya mentioned this pull request Nov 5, 2024
Open
@cat-in-136 cat-in-136 marked this pull request as ready for review December 1, 2024 10:44
@cat-in-136 cat-in-136 merged commit 6a5119a into master Dec 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cat-in-136 @nishidayuya