塗りつぶしのアルゴリズムを変更 #10
Open
塗りつぶしのアルゴリズムを変更 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSlime-s
force-pushed
the
SSlime/add-canvas
branch
from
40fa14c
to
79f2108
Compare
SSlime-s
force-pushed
the
SSlime/change-fill-algorithm
branch
from
002bbb7
to
93ecde7
Compare
Deploying nascalay-v2-preview with
|
| Latest commit: |
e923999
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3fb87a71.nascalay-v2-preview.pages.dev |
| Branch Preview URL: | https://sslime-change-fill-algorithm.nascalay-v2-preview.pages.dev |
ras0q
reviewed
May 31, 2024
Comment on lines
62
to
72
| interface Operations { | ||
| /** | ||
| * キャンバス内の有効な座標かつ targetColor と等しいかどうかを返す | ||
| */ | ||
| inside: (x: number, y: number) => boolean; | ||
| /** | ||
| * キャンバスの座標 (x, y) を塗りつぶす色で塗る | ||
| */ | ||
| set: (x: number, y: number) => void; | ||
| pushSeed: (seed: Seed) => void; | ||
| } |
There was a problem hiding this comment.
bucketFill に近接させたかったけどまぁあんま変わんないから一番上にしました
| /** | ||
| * キャンバスの座標 (x, y) を塗りつぶす色で塗る | ||
| */ | ||
| set: (x: number, y: number) => void; |
There was a problem hiding this comment.
Suggested change
| set: (x: number, y: number) => void; | |
| draw: (x: number, y: number) => void; |
There was a problem hiding this comment.
命名 wiki からだからあんま変えたくない (wiki 読んだ人がそのまま読めるようにしてるので)
| /** | ||
| * キャンバス内の有効な座標かつ targetColor と等しいかどうかを返す | ||
| */ | ||
| inside: (x: number, y: number) => boolean; |
There was a problem hiding this comment.
色判定までするなら
Suggested change
| inside: (x: number, y: number) => boolean; | |
| canDraw: (x: number, y: number) => boolean; |
There was a problem hiding this comment.
命名 wiki からだからあんま変えたくない (wiki 読んだ人がそのまま読めるようにしてるので)
| y < yRange[1] && | ||
| likeEqualColor(data[y][x], targetColor); | ||
| } | ||
| function createSet(data: Color[][], color: Color): Operations["set"] { |
There was a problem hiding this comment.
createInsideもややだけど使うのoperationsの初期化のときだけだしラップするまででもなさそう
好みで
There was a problem hiding this comment.
しないとしたら bucketFill の関数内にそのまま書くってこと？
There was a problem hiding this comment.
そう、pushSeedがそうだからここだけ切り出してるのが気になった
Deploying nascalay-v2-storybook with
|
| Latest commit: |
e923999
|
| Status: | 🚫 Build failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
差分を見やすくするために canvas 追加のやつに向けてます
ref: https://en.wikipedia.org/wiki/Flood_fill
区間ベースで持つことで見るピクセル数を減少させるように
アルゴリズムが正当か は見なくていいです (コメントちゃんと書いたから見てもいいけど)
https://sslime-change-fill-algorithm.nascalay-v2-preview.pages.dev/tmp2 で試せます