Include convention (eg. solargraph-rspec) pins in document_symbols #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekemula
commented
Oct 3, 2024
| end | ||
|
|
||
| def convention_pins=(pins) | ||
| # unmemoizing the document_symbols in case it was called from any of convnetions |
There was a problem hiding this comment.
For example, solargraph-rails:
This leads to subsequent convention pins not being included, hence we need to clear the memorization after all convention pins are collected.
lekemula
commented
Oct 3, 2024
| @@ -6,6 +6,8 @@ class Solargraph::LanguageServer::Message::TextDocument::DocumentSymbol < Solarg | |||
| def process | |||
| pins = host.document_symbols params['textDocument']['uri'] | |||
| info = pins.map do |pin| | |||
| next nil unless pin.location&.filename | |||
There was a problem hiding this comment.
solargraph-rspec happens to be adding some RSpec DSL methods without a filename, which should be excluded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
It looks like currently the additional pins added from conventions are not included in documentSymbol request.
This PR adds them, thus enabling finding and easier navigation between
RSpecdescribe/contextblocks via solargraph-rspec plugin: