Implement Go To Type Definition #717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekemula
commented
May 27, 2024
| @@ -630,6 +639,7 @@ def default_configuration | |||
| 'hover' => true, | |||
| 'symbols' => true, | |||
| 'definitions' => true, | |||
| 'typeDefinitions' => true, | |||
There was a problem hiding this comment.
I suppose this config should be added to the IDE plugins too?
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_typeDefinition All the necessary pieces were in place, nothing fancy changed, mostly just exposing the functionality for LanguageServer. The only "functionality" added is `ComplexType#namespaces` which also utilizes existing implementation.
lekemula
force-pushed
the
go-to-type-definition
branch
from
14a17c5 to
cfa126d
Compare
|
Hey @castwide, any chance that we could move forward here? I believe this is a very useful low-hanging fruit that could be quite helpful in navigating the codebase. Looking forward to your suggestions on improving the proposed changes. Also would be nice if you could also take a look at some other PRs of mine, some of which are a few months old now. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_typeDefinition
Demo in VScode (since in VIM everything is too fast 🤪)
All the necessary pieces were in place, and nothing fancy changed, mostly just exposing the functionality for LanguageServer. Almost feels like an easter egg for a new contributor like me 😄.
The only "functionality" added is
ComplexType#namespaceswhich also utilizes existing implementation.