Remove Rspec convention in favour of solargraph-rspec plugin #716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
ICYMI: #683 (comment)
The new plugin includes all existing functionality + much more! (See gem's README: https://github.com/lekemula/solargraph-rspec.)
After you have given it a try and find it worthy, being that
rspec
is the de-facto preferred testing framework in Ruby, would it make sense to:solargraph-rails
in the Readme/Documentation?remove the
'exclude' => ['spec/**/*', 'test/**/*', 'vendor/**/*', '.bundle/**/*'],
exclude: ['spec/**/*']
folder as a default config?solargraph/lib/solargraph/workspace/config.rb
Line 151 in d610a6b
Looking forward to your feedback.
Resolves: #683