Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete global methods from a file inside modules/classes #714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lekemula
Copy link

@lekemula lekemula commented May 25, 2024

Hi,

I noticed this issue while trying to make the "normal ruby" method completion work for RSpec context blocks initially in https://github.com/lekemula/solargraph-rspec. Even though I ultimately ended up with a different solution, I thought to still port this change as it's still a valid ruby code, albeit a rare case in real life (?).

# thing.rb
def some_method;end

class Thing
  def foo
    some_
    #   ^ this does not work
  end
end

@lekemula lekemula marked this pull request as ready for review May 25, 2024 17:21
@lekemula lekemula force-pushed the complete-root-methods-in-classes branch from 4ef28a7 to 580ce02 Compare May 25, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant