Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update rbs to 3.0 #662

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

tk0miya
Copy link

@tk0miya tk0miya commented May 15, 2023

Now solargraph depends on RBS-2.x. So we can't use Solargraph and the latest RBS. So this updates the dependency to RBS 3.0. What do you think?

tk0miya added 2 commits May 15, 2023 11:21
The "set" has been merged into the Ruby Core and RBS has been drop
support since v3.0.  So current spec implementation will not work with
RBS-3.x.
@D-system
Copy link

D-system commented Feb 5, 2024

@castwide any reservation to update to rbs 3.0?

Copy link

@qbantek qbantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lekemula
Copy link

lekemula commented Oct 3, 2024

Hey @tk0miya / @castwide, is there anything holding this from being shipped?

This is kinda blocking merging solargraph-rspec into Gitlab's codebase which would serve as a great source of feedback for improving it further.

https://gitlab.com/gitlab-org/gitlab/-/merge_requests/157114#note_1982725864

Thanks!

@tk0miya
Copy link
Author

tk0miya commented Oct 3, 2024

No problem from my side. I'm also waiting to merge this to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants