added failing (and passing?) tests #573
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've been following along with a couple old issues some have reported, and that I have personally experienced with renaming.
The respective issues I think are related are #135 and #107.
I am not familiar with language server protocol, but was able to add a few tests that correlate with the renaming bug that I and others have had in our respective editors. The first 2 tests are related to comments at the bottom of #135, and the extra element in
rename.result[:changes]['file:///file.rb']I believe is the 'overlapping ranges error'. Both of those tests are currently failing.The final test at the bottom is for #107, but seems to be passing, so it's just an added test at this point.
If time permits, I'll come back soon and figure out how to get these tests to pass, but wanted to post the PR in case it sparks an idea for anyone more familiar with LSP.