Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tolerance checking approach and tweak yaml configs #2592

Merged
merged 29 commits into from
Sep 19, 2024
Merged

Conversation

lintool
Copy link
Member

@lintool lintool commented Sep 7, 2024

  • Wrapped up Get rid of extra options for HNSW indexes #2531 - revert to "default settings" for dense indexing - previously was applied for some configs, but not others. This PR makes indexing options consistent across all configs.
  • Tolerance values are now stored directly in the yaml configs, not centralized in run_regression.py
  • Changed MS MARCO v1 passage Cohere regressions to use same metrics as other regressions.
  • Updated topics - removed extra queries for BGE BEIR BioASQ

@lintool lintool marked this pull request as draft September 7, 2024 15:29
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (204bc87) to head (a8ae8f9).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2592   +/-   ##
=========================================
  Coverage     65.56%   65.56%           
  Complexity     1479     1479           
=========================================
  Files           225      225           
  Lines         13012    13012           
  Branches       1551     1551           
=========================================
  Hits           8531     8531           
  Misses         3953     3953           
  Partials        528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool lintool changed the title Tweak yaml configs Refactor tolerance checking approach and tweak yaml configs Sep 15, 2024
@lintool lintool requested a review from MXueguang September 17, 2024 00:20
@lintool lintool marked this pull request as ready for review September 17, 2024 00:20
@lintool lintool merged commit 9e0cd5b into master Sep 19, 2024
1 check failed
@lintool lintool deleted the refactoring branch September 19, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants