Add to onboarding reproduction logs #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lintool
reviewed
Nov 1, 2023
|
Please continue along the onboarding path and we'll take a look at it when you reach the end. |
|
Sure. I will notify you during the path |
|
I have completed all the onboarding path steps. The operating system on which I completed this task was Windows. All the commands and code executed without any issues, and only some of the commands were adjusted to be compatible with the Windows operating system to ensure proper execution. Other files are changed in pyserini repository. |
lintool
reviewed
Nov 3, 2023
docs/start-here.md
Outdated
| @@ -336,3 +336,4 @@ If you think this guide can be improved in any way (e.g., you caught a typo or t | |||
| + Results reproduced by [@gituserbs](https://github.com/gituserbs) on 2023-10-07 (commit [`d88003c`](https://github.com/castorini/anserini/commit/d88003c71ae7b2e3da65885c709f61aac57611b4)) | |||
| + Results reproduced by [@shayanbali](https://github.com/shayanbali) on 2023-10-12 (commit [`8194b8e`](https://github.com/castorini/anserini/commit/8194b8e91fe799fcb0d3b4348e9d710a0aa1ad26)) | |||
| + Results reproduced by [@oscarbelda86](https://github.com/oscarbelda86) on 2023-10-30 (commit [`824154b`](https://github.com/castorini/anserini/commit/824154bf9226b2f44146a5b258f0dfb2042eb583)) | |||
| + Results reproduced by [@shakibaam](https://github.com/shakibaam) on 2023-11-1 (commit [`92f16f5`](https://github.com/castorini/anserini/commit/92f16f5ae7bf8ff05a12b2222d9919fd75c1fa81)) | |||
|
I apologize for the issues in the pull requests. They have been resolved |
lintool
reviewed
Nov 3, 2023
docs/experiments-msmarco-passage.md
Outdated
| @@ -442,3 +442,4 @@ The BM25 run with default parameters `k1=0.9`, `b=0.4` roughly corresponds to th | |||
| + Results reproduced by [@shayanbali](https://github.com/shayanbali) on 2023-10-12 (commit [`8194b8e`](https://github.com/castorini/anserini/commit/8194b8e91fe799fcb0d3b4348e9d710a0aa1ad26)) | |||
| + Results reproduced by [@gituserbs](https://github.com/gituserbs) on 2023-10-14 (commit [`8194b8e`](https://github.com/castorini/anserini/commit/8194b8e91fe799fcb0d3b4348e9d710a0aa1ad26)) | |||
| + Results reproduced by [@oscarbelda86](https://github.com/oscarbelda86) on 2023-10-31 (commit [`4c06d8a`](https://github.com/castorini/anserini/commit/4c06d8a6de655caf9c3dc4d6d1977b58f68e3992)) | |||
| + Results reproduced by [@shakibaam](https://github.com/shakibaam) on 2023-11-03 (commit [`eaa49d1`](https://github.com/castorini/anserini/commit/eaa49d17c7e832261be2ffb8b9011fea3bd1fd85)) | |||
There was a problem hiding this comment.
This is not a valid commit id.
When you visit the URL: eaa49d1
You get the following error:
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
You want the commit id of the main Anserini trunk.
lintool
reviewed
Nov 3, 2023
docs/start-here.md
Outdated
| @@ -336,3 +336,4 @@ If you think this guide can be improved in any way (e.g., you caught a typo or t | |||
| + Results reproduced by [@gituserbs](https://github.com/gituserbs) on 2023-10-07 (commit [`d88003c`](https://github.com/castorini/anserini/commit/d88003c71ae7b2e3da65885c709f61aac57611b4)) | |||
| + Results reproduced by [@shayanbali](https://github.com/shayanbali) on 2023-10-12 (commit [`8194b8e`](https://github.com/castorini/anserini/commit/8194b8e91fe799fcb0d3b4348e9d710a0aa1ad26)) | |||
| + Results reproduced by [@oscarbelda86](https://github.com/oscarbelda86) on 2023-10-30 (commit [`824154b`](https://github.com/castorini/anserini/commit/824154bf9226b2f44146a5b258f0dfb2042eb583)) | |||
| + Results reproduced by [@shakibaam](https://github.com/shakibaam) on 2023-11-01 (commit [`92f16f5`](https://github.com/castorini/anserini/commit/92f16f5ae7bf8ff05a12b2222d9919fd75c1fa81)) | |||
|
I apologize for the earlier issue. I have now used the commit ID from the main trunk of both repositories, 'pyserini' and 'anserini,' and added it to the log. Is everything okay now? |
lintool
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operating System: Windows 10 Enterprise
Environment: Git Bash