Skip to content

Commit

Permalink
[FEATURE] Updating typoscript view configuration to use the new 6.2 way.
Browse files Browse the repository at this point in the history
  • Loading branch information
Peter Soots committed Sep 17, 2014
1 parent 7692447 commit d048af4
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions Configuration/TypoScript/setup.txt
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
plugin.tx_cicregister {
vendorName = CIC
view {
templateRootPath = {$plugin.tx_cicregister.view.templateRootPath}
partialRootPath = {$plugin.tx_cicregister.view.partialRootPath}
layoutRootPath = {$plugin.tx_cicregister.view.layoutRootPath}
templateRootPaths {
10 = {$plugin.tx_cicregister.view.templateRootPath}
}
partialRootPaths {
10 = {$plugin.tx_cicregister.view.partialRootPath}
}
layoutRootPaths {
10 = {$plugin.tx_cicregister.view.layoutRootPath}
}
}
settings {
views {
Expand Down

2 comments on commit d048af4

@georgringer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least in AbstractBehavior is there now a problem because
$templateRootPath = \TYPO3\CMS\Core\Utility\GeneralUtility::getFileAbsFileName($extbaseFrameworkConfiguration['view']['templateRootPath']);
is now empty

@petersooley
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @georgringer, it looks like you're right. Since making that change, we haven't been using the sendTemplateEmail function from the AbstractBehaviors class.

I have made an issue and will try to get it later today. Ideally, there would be only one place where emails are sent from. That way you can control any logging or email whitelisting in one place. I don't think AbstractBehavior is the best place to have a "sendEmail" function. We have been using an EmailService from a separate extension to abstract away some of the gritty configuration details and put them into typoscript.

https://github.com/castiron/cicbase/blob/master/Classes/Service/EmailService.php

#14

Please sign in to comment.