Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

Small fixes for for Mingw32 and Mingw64 #306

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Small fixes for for Mingw32 and Mingw64 #306

wants to merge 9 commits into from

Conversation

ienapliss
Copy link

But linking is still broken.

castano
castano suggested changes Jul 14, 2020
View reviewed changes
Copy link
Owner

@castano castano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status of this? Did you ever get to fix the linker errors?

src/nvthread/Mutex.cpp
@@ -2,15 +2,16 @@

#include "Mutex.h"

#if NV_OS_WIN32
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather use NV_OS_WIN32 && !NV_OS_MINGW like in the #if below.

src/nvthread/Thread.cpp
@@ -2,11 +2,11 @@

#include "Thread.h"

#if NV_OS_WIN32
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@castano castano castano requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ienapliss @castano