Changing TransactionV1 structure. From now on a TransactionV1 con…
#4890
+4,723
−3,870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
force-pushed
the
restructuring_transaction_datatype
branch
4 times, most recently
from
4b80341
to
e4679ab
Compare
gRoussac
reviewed
Sep 17, 2024
gRoussac
reviewed
Sep 17, 2024
zajko
force-pushed
the
restructuring_transaction_datatype
branch
3 times, most recently
from
92b3a87
to
9252a9b
Compare
zajko
force-pushed
the
restructuring_transaction_datatype
branch
11 times, most recently
from
ed9227d
to
e009a45
Compare
zajko
force-pushed
the
restructuring_transaction_datatype
branch
from
269ff6f
to
43b8bcf
Compare
zajko
requested review from
EdHastingsCasperAssociation,
mpapierski,
fizyk20,
gRoussac and
darthsiroftardis
…s of `hash`, `payload` and `approvals`. `payload` is a merge of `header` and `body` concepts from before. `body` is not represented in a type-constrained way, instead we use an amorphic `fields` of type `BTreeMap<u16, Bytes>` which is more resistant to future changes.
zajko
force-pushed
the
restructuring_transaction_datatype
branch
from
68347b0
to
078e98e
Compare
gRoussac
reviewed
Oct 10, 2024
gRoussac
reviewed
Oct 10, 2024
added 2 commits
October 11, 2024 10:16
EdHastingsCasperAssociation
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sists of
hash,payloadandapprovals.payloadis a merge ofheaderandbodyconcepts from before.bodyis not represented in a type-constrained way, instead we use an amorphicfieldsof typeBTreeMap<u16, Bytes>which is more resistant to future changes.