-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable wasm32 compilation and runtime of the binary-port-access lib #1
Open
gRoussac
wants to merge
36
commits into
master
Choose a base branch
from
rustSDK-feat-2.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt-client into rustSDK-feat-2.0 # Conflicts: # Cargo.lock
…rt-client into rustSDK-feat-2.0 # Conflicts: # Cargo.lock # binary_port_access/Cargo.toml
# Conflicts: # Cargo.toml # binary_port_access/Cargo.toml
# Conflicts: # Makefile
…rt-client into rustSDK-feat-2.0 # Conflicts: # .github/workflows/ci-cd.yml # Makefile
gRoussac
changed the title
Rust sdk feat 2.0
Enable wasm32 compilation and runtime of the binary-port-access lib
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As MVP Enable wasm32 compilation and runtime of the nested binary-port-access library.
Basically expose the binary-port-access lib as intended for Rust (non wasm32) / NodeJs (wasm32) / Browser WebSockets (wasm32)
net
module.Note that browsers have CORS (Cross-Origin Resource Sharing) restrictions, so the WebSocket requests should/may be addressed to a WebSocket proxy.
The added
communication
module provides both shared and platform-specific functionalities for managing communication processes.-
common.rs
-
wasm32.rs
Contains WebAssembly-specific (wasm32
target) communication utilities, available only when compiled for WebAssembly.A TODO remains to replace usage of
js_sys::eval
on Node.js (script is local, not remote so no security issue but nice to change to global function execution withjs_sys::Reflect::apply
which should be more appropriate)NodeJs
Chromium Browser