Add preview param support for @Paparazzi #1554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-powell
force-pushed
the
akent/simple-preview/plugin-implementation
branch
from
b81c705
to
f4a6041
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
from
61af140
to
d885062
Compare
geoff-powell
force-pushed
the
akent/simple-preview/plugin-implementation
branch
from
f4a6041
to
023b95f
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
from
d885062
to
e6f1ff8
Compare
geoff-powell
force-pushed
the
akent/simple-preview/plugin-implementation
branch
2 times, most recently
from
32a0b1d
to
e6c20a3
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
from
e6f1ff8
to
03d8aa9
Compare
geoff-powell
force-pushed
the
akent/simple-preview/plugin-implementation
branch
from
e6c20a3
to
1fa7c72
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
2 times, most recently
from
ae7db39
to
563618f
Compare
geoff-powell
force-pushed
the
akent/simple-preview/plugin-implementation
branch
2 times, most recently
from
7adf78e
to
02b251d
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
2 times, most recently
from
ff32d9d
to
1f4a052
Compare
geoff-powell
force-pushed
the
akent/simple-preview/plugin-implementation
branch
from
02b251d
to
8c72a58
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
2 times, most recently
from
32f231c
to
6cf1056
Compare
geoff-powell
force-pushed
the
akent/simple-preview/plugin-implementation
branch
from
8c72a58
to
280f576
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
2 times, most recently
from
3dd2b8f
to
aefdcf5
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
3 times, most recently
from
7dc395e
to
afd25fc
Compare
geoff-powell
force-pushed
the
akent/simple-preview/plugin-implementation
branch
from
280f576
to
c76980f
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
from
afd25fc
to
fe6a718
Compare
geoff-powell
force-pushed
the
akent/simple-preview/plugin-implementation
branch
2 times, most recently
from
04f15e7
to
38b4698
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
from
fe6a718
to
1a19a7a
Compare
geoff-powell
force-pushed
the
akent/simple-preview/plugin-implementation
branch
from
38b4698
to
a6c4f52
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
3 times, most recently
from
6375ea6
to
4de1774
Compare
geoff-powell
commented
Nov 20, 2024
paparazzi-annotations/build.gradle
Outdated
| @@ -3,5 +3,6 @@ apply plugin: 'org.jetbrains.kotlin.plugin.compose' | |||
| apply plugin: 'com.vanniktech.maven.publish' | |||
|
|
|||
| dependencies { | |||
| implementation libs.compose.runtime | |||
| compileOnly libs.compose.runtime | |||
| compileOnly libs.tools.layoutlib | |||
There was a problem hiding this comment.
nit: I don't love having to depend on this but we need access to android.content.res.Configuration used in preview. Maybe we could hardcode these values instead?
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
2 times, most recently
from
de71fe3
to
3f13d10
Compare
geoff-powell
force-pushed
the
akent/preview/preview-params
branch
from
3f13d10
to
e279e1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to read
@PreviewParametersfor @composable's with the @paparazzi annotationfixes #1687