Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Nav Bar): vertical button alignment #98

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

unseen-ninja
Copy link
Collaborator

partially addresses #89

@unseen-ninja unseen-ninja merged commit 2f70e86 into main Aug 23, 2023
@wiillou
Copy link

wiillou commented Aug 23, 2023

this commit did not work for me, however, changing:

[cascade-nav-bar.css] [line:47]

.urlbar-page-action .urlbar-icon { margin-top: 3px !important; }

from 6 to 3 seemed to fix it for me

@unseen-ninja
Copy link
Collaborator Author

Yeah.. sometimes it's really weird how pixel values behave on different devices.. I'm looking into another potential rewrite of Cascade in order to get around these issues.

@wiillou
Copy link

wiillou commented Aug 23, 2023

Yea, even with the change i made when i click on the URL bar it goes upwards a bit :c . Kinda annoying that you have to rewrite it to properly fix something like this.

@unseen-ninja
Copy link
Collaborator Author

Well, yeah.. But it was an oversight on my end from the start, I guess. So it's just fair that I have to put in work in order to avoid it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants