Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cii badge to readme.md #461

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

microwavables
Copy link

No description provided.

signed-off-by: Nanci Lancaster <[email protected]>

update readme cii badge

signed-off-by: Nanci Lancaster <[email protected]>
@praveenrewar
Copy link
Member

Closing and re-opening the PR as the tests seems to be hung up.

@microwavables
Copy link
Author

@praveenrewar checks still aren't triggering

@praveenrewar
Copy link
Member

Thanks to this comment, I realised that we had branch protection rules that require these 2 checks to pass before a PR can be merged, and we also have some paths added to path-ignore which would prevent these checks from being run for updated to markdown files which was conflicting. For now I have removed those branch protection rules (I think those were experimental as we don't have them in other tools) and the PR now says "All checks have passed" 🚀

@praveenrewar praveenrewar merged commit 59a82ca into carvel-dev:develop Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants