Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the error state for "username already exists" #723

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bitfalt
Copy link

@bitfalt bitfalt commented Sep 14, 2024

Solves #671

  • Change the error message in Signup and Login
  • Add the button to Signup modal
  • Add the button to Login modal

Copy link

vercel bot commented Sep 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Sep 14, 2024 9:30pm
profile ✅ Ready (Inspect) Visit Preview Sep 14, 2024 9:30pm
ui ✅ Ready (Inspect) Visit Preview Sep 14, 2024 9:30pm
ui-next ✅ Ready (Inspect) Visit Preview Sep 14, 2024 9:30pm

@bitfalt
Copy link
Author

bitfalt commented Sep 14, 2024

Hi! I'm trying to test the button I added to check if it displays correctly and then start modifying the styling according to the Figma. However, I'm getting some problems when trying to open the modal in localhost:3002.

I'm getting the following error:
image

From the error I see that it is trying to make a request to localhost:8001/x/starknet/sepolia?paymaster=true. However I don't have anything running in localhost:8001. I assume I need to run the local devnet, but I was just wondering if there is a specific configuration or something needed.

I followed all the instructions in the README regarding Frontend Development.

@clicksave
Copy link

cc @broody any guidance on the issue Daniel is running into?

@broody
Copy link
Contributor

broody commented Sep 18, 2024

@bitfalt thanks for the PR! Sorry, but the way we're setup currently is this requires some of our backend services to be running locally. I don't think there is a good alternative rn.

Let me help u push this PR across tho, again thanks for trying to tackle this!

@bitfalt
Copy link
Author

bitfalt commented Sep 18, 2024

okay okay! Could I dm you on Telegram or Discord to have better communication? I might need some guidance regarding proper implementation. I already modified the messages, but I usually struggle with setting up frontend related stuff, so some proper guidance would be amazing! :D

@broody
Copy link
Contributor

broody commented Sep 18, 2024

okay okay! Could I dm you on Telegram or Discord to have better communication? I might need some guidance regarding proper implementation. I already modified the messages, but I usually struggle with setting up frontend related stuff, so some proper guidance would be amazing! :D

Yeah absolutely, drop by discord here https://discord.gg/cartridge

Or you can do me on telegram at @broody_eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants