Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(advancer): add the repository and end-to-end tests to the advancer #528

Closed
wants to merge 4 commits into from
Closed

feat(advancer): add the repository and end-to-end tests to the advancer #528

wants to merge 4 commits into from

Conversation

renan061
Copy link
Contributor

No description provided.

@renan061 renan061 added the #feat:machine-advancer Feature: machine advancer label Jul 19, 2024
@renan061 renan061 added this to the 2.0.0 milestone Jul 19, 2024
@renan061 renan061 self-assigned this Jul 19, 2024
@renan061 renan061 changed the title Feature/machine advancer feat: add machineadvancer package Jul 19, 2024
@renan061 renan061 changed the base branch from main to feature/rollups-machine July 19, 2024 16:40
@renan061 renan061 force-pushed the feature/rollups-machine branch 2 times, most recently from 10cb428 to e55b146 Compare July 19, 2024 16:47
@renan061 renan061 force-pushed the feature/machine-advancer branch 2 times, most recently from 2e2a378 to 3688205 Compare July 19, 2024 16:58
@renan061 renan061 force-pushed the feature/rollups-machine branch from e55b146 to f749688 Compare July 19, 2024 16:59
@renan061 renan061 force-pushed the feature/machine-advancer branch 3 times, most recently from 41271e8 to 261d752 Compare July 22, 2024 09:00
@renan061 renan061 changed the title feat: add machineadvancer package feat: add advancer package Jul 22, 2024
GMKrieger
GMKrieger requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@GMKrieger GMKrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every change in the database that is not directly related to the machine advancer, e.g. updating the migrations, should be in a separate commit.

Aside from that, the code looks very solid; just some minor comments.

.../repository/migrations/000001_create_application_input_claim_output_report_nodeconfig.up.sql Outdated Show resolved Hide resolved
internal/repository/base.go Outdated Show resolved Hide resolved
internal/repository/advancer.go Outdated Show resolved Hide resolved
test/advancer/advancer_test.go Show resolved Hide resolved
internal/repository/advancer.go Outdated Show resolved Hide resolved
@renan061 renan061 force-pushed the feature/machine-advancer branch 2 times, most recently from 915eb8e to ace4d2e Compare July 23, 2024 08:41
@renan061 renan061 marked this pull request as ready for review July 23, 2024 08:41
@renan061 renan061 force-pushed the feature/machine-advancer branch from ace4d2e to ac95f6b Compare July 23, 2024 08:44
torives
torives reviewed Jul 23, 2024
View reviewed changes
internal/node/advancer/service/service.go Outdated Show resolved Hide resolved
internal/node/advancer/service/service.go Outdated Show resolved Hide resolved
internal/node/nodemachine/machine.go Outdated Show resolved Hide resolved
internal/node/nodemachine/machine.go Outdated Show resolved Hide resolved
internal/node/nodemachine/machine.go Outdated Show resolved Hide resolved
internal/repository/schemamanager.go Outdated Show resolved Hide resolved
test/advancer/advancer_test.go Outdated Show resolved Hide resolved
internal/node/advancer/advancer.go Outdated Show resolved Hide resolved
internal/repository/advancer.go Outdated Show resolved Hide resolved
test/advancer/advancer_test.go Show resolved Hide resolved
fmoura
fmoura requested changes Jul 24, 2024
View reviewed changes
internal/node/nodemachine/machine.go Outdated Show resolved Hide resolved
internal/node/nodemachine/machine.go Outdated Show resolved Hide resolved
internal/repository/advancer.go Show resolved Hide resolved
internal/repository/advancer.go Show resolved Hide resolved
test/advancer/advancer_test.go Outdated Show resolved Hide resolved
fmoura
fmoura requested changes Jul 24, 2024
View reviewed changes
internal/repository/advancer.go Outdated Show resolved Hide resolved
internal/node/advancer/advancer.go Outdated Show resolved Hide resolved
marcelstanley
marcelstanley reviewed Aug 1, 2024
View reviewed changes
internal/node/advancer/service/service.go Outdated Show resolved Hide resolved
internal/node/nodemachine/machine.go Outdated Show resolved Hide resolved
internal/node/nodemachine/machine.go Outdated Show resolved Hide resolved
internal/repository/advancer.go Outdated Show resolved Hide resolved
internal/repository/advancer.go Outdated Show resolved Hide resolved
internal/repository/advancer.go Outdated Show resolved Hide resolved
internal/repository/advancer.go Outdated Show resolved Hide resolved
internal/repository/base.go Outdated Show resolved Hide resolved
@renan061 renan061 force-pushed the feature/rollups-machine branch 6 times, most recently from 2a12e3d to d31ee75 Compare August 13, 2024 18:44
Base automatically changed from feature/advancer-service to next/2.0 August 27, 2024 16:16
@renan061 renan061 force-pushed the feature/machine-advancer branch 3 times, most recently from e197c24 to b5e6985 Compare August 27, 2024 16:45
@renan061 renan061 marked this pull request as ready for review August 27, 2024 16:53
@renan061 renan061 force-pushed the feature/machine-advancer branch 14 times, most recently from da577e1 to 6d27c54 Compare August 30, 2024 12:59
@renan061 renan061 changed the base branch from next/2.0 to feature/minor-repository-refactor August 30, 2024 13:00
@renan061 renan061 force-pushed the feature/machine-advancer branch from a7830b5 to c99abf0 Compare August 30, 2024 13:06
Base automatically changed from feature/minor-repository-refactor to next/2.0 August 30, 2024 13:39
@renan061 renan061 force-pushed the feature/machine-advancer branch from 3cd09a0 to 6159eb0 Compare August 30, 2024 13:42
@renan061 renan061 force-pushed the feature/machine-advancer branch from 6159eb0 to 0d348fb Compare August 30, 2024 13:43
@renan061 renan061 closed this Aug 30, 2024
@renan061 renan061 deleted the feature/machine-advancer branch August 30, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMKrieger GMKrieger GMKrieger requested changes

@marcelstanley marcelstanley marcelstanley left review comments

@torives torives torives left review comments

@fmoura fmoura fmoura requested changes

Assignees

@renan061 renan061

Labels
#feat:machine-advancer Feature: machine advancer
Projects
Node Unit
Status: ✅ Done
Milestone
2.0.0
5 participants
@renan061 @fmoura @torives @marcelstanley @GMKrieger